Le dimanche 27 juillet 2008, amdfanatyk a écrit :
> Hi,
> I've prepared two patches for Kopete. 

Hi, thanks for the patch

> First of them solves history scrolling problem in chat window.

maxValue() is deprecated, please use maximum() instead.

But i don't really understand that patch. Why does it works?
I'm also afraid it can led to a kind of infinite loop if you open an empty 
chat window.


> Second one is related to status notifications.

I don't really see the interest of that option. So I'm not really in favor of 
that.
Also, it seems you don't disable notification on new messages. (it's in the 
viewmanager)

(and you should run fixuifiles)

> I've also included extension for nowlistening plugin. 

This looks ok.
But please add the GPL licence header to them.


Thanks for contributing
-- 
Olivier

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to