----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/197/#review184 -----------------------------------------------------------
Instead of this QBuffer *buf = new QBuffer; buf->setData(content); buf->open(QIODevice::ReadOnly); use m_stream = new QDataStream(content); this will have the same effect and you don't have to delete the QBuffer (that you don't in your patch) Also I don't think the reserve to resize changes are necessary because [] will resize it. Roman - Roman On 2008-02-24 15:36:32, Carlo Segato wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://mattr.info/r/197/ > ----------------------------------------------------------- > > (Updated 2008-02-24 15:36:32) > > > Review request for Kopete. > > > Summary > ------- > > Sending and receiving messages still doesn't work but at least it doesn't > crash :) > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/msn/msnsocket.cpp > > Diff: http://mattr.info/r/197/diff > > > Testing > ------- > > > Thanks, > > Carlo > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
