> On 2008-02-23 10:33:04, Matt Rogers wrote: > > hmm, I wonder if you could tie the resize to the layout timer instead of > > having to create a new one. That removes another option ( the one about how > > long to wait to resize ) and removes a timer. :) > > > > If you can't do it, then we'll go with this way and just commit the patch > > as-is. > > Charles Connell wrote: > I don't think it would be a good idea to tie the two timers together > because: > a) Some people might want them to be different (after all you can't even > change the layout timer) > b) People who have disabled contact list animations will see almost no > difference between sudden resizing and layout-timer resizing > > Matt Rogers wrote: > I don't care if some people want them to be different. > > Why is people seeing no difference between sudden resizing and > layout-timer resizing a bad thing?
As I've already said, sudden resizing means resizing every time a buddy come or goes, which might be very frequent, and therefore very annoying to the user. However, we can do it that way if you want. The layout timer is set to 30 milliseconds, making it, for all purposes, the same as sudden resizing. Simplifying is good, so my recommendation for that is to do "sudden resizing", which to me means resizing every time the contact list changes contents. (aka after the layout timer has fired and everything is laid out) - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://mattr.info/r/171/#review176 ----------------------------------------------------------- On 2008-02-23 10:21:47, Charles Connell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://mattr.info/r/171/ > ----------------------------------------------------------- > > (Updated 2008-02-23 10:21:47) > > > Review request for Kopete. > > > Summary > ------- > > This is a patch that resizes the main window automatically, so that it nicely > fits the size of the contact list tree. This is set up as an off-by-default > option. The user can specify a maximum size, so that it never gets bigger > than one's screen, and also a minimum size. > > The way this is done is by reevaluating the needed size for the contact list > every X seconds (once again, user may specify). The timer will not run if the > contact list is not maximized. Also, it will not resize if the user's cursor > is inside the main window, as this would likely cause undue frustration. > > Advantages: - Always a nicely presented main window. > - Keep up with feature sets in competitors (some of them already > have this). > > Disadvantages: - If window is visible to user, it is distracting to see it > resizing spontaneously. > - Repeatedly firing timer may interfere with sleep mechanisms > on systems. > - Repeatedly firing timer adds CPU usage to an otherwise idle > process. Bloat is BAD. > > Of course, this is all off by default, and even if the setting is enabled, it > only takes effect when the main window is maximized. > > > This addresses bug 154955. > > > Diffs > ----- > > > trunk/KDE/kdenetwork/kopete/kopete/config/appearance/appearanceconfig_advanced.ui > trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.h > trunk/KDE/kdenetwork/kopete/kopete/kopetewindow.cpp > trunk/KDE/kdenetwork/kopete/libkopete/kopeteappearancesettings.kcfg > trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistview.h > trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistviewitem.h > trunk/KDE/kdenetwork/kopete/libkopete/ui/kopetelistviewitem.cpp > > Diff: http://mattr.info/r/171/diff > > > Testing > ------- > > works for me after during a few minutes of testing > > > Screenshots > ----------- > > Config options rev. 2 > http://mattr.info/r/171/s/19/ > > > Thanks, > > Charles > > _______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
