Le jeudi 28 juin 2007, Ezequiel R. Aguerre a écrit : > Hi, > this is the patch of the other day ported to KDE 4. > It lets us export the Latex formulae as INK Draw gif's, however, it doesn't > work with MSN Plus yet (it seems there is some kind of wrong base64 > encoding in that extension).
I have read brievly the patch, here are some notes:
> void LatexPlugin::slotMessageAboutToShow( Kopete::Message& msg )
> {
>+ if ( msg.direction() != Kopete::Message::Inbound )
>+ return;
>+
Why did you disable the latex parsing of outbound message ? Not all messages
can be represented as a single image, and maybe the protocol doesn't support
sending images at all.
anyway, message that have already been parsed should not be parsed again. We
need to find a better way to detect if the message has been parsed. (checking
for an <img/>)
>- config->setGroup("Latex Plugin");
>-
>- if(!config->readEntry("ParseOutgoing", false))
>- return;
I think a config option should stay
>+ static QMap < QString, QString > latexFormulaMap;
>+ QMap < QString, QString >::ConstIterator it = latexFormulaMap.constFind
>(
>latexFormula );
>+
>+ if ( it != latexFormulaMap.constEnd () )
>+ return it.value();
maybe considering the use of QCache here. (but i'm not sure itis required to
have a cache. i even think there should not be a cache.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
