Hi!

Thank you for your interest in this plugin.

> I've tested it and noticed few bugs.  When generating fingerprints, kpoete
> get freeze , and i had once a crash when chatting (unfortunately i don't
> have the backtrace)
>
The freeze is because libotr uses all ressources while generating the private 
key. This issue should occur only once for each account because the generated 
keys are stored permanently. Also other IMs using libotr have the same issue. 
Anyway, I will try to make this situation more userfriendlier.

At the moment I don't know what to say about the crash since I never noticed 
any crashs and you are the first complaining about. Please let me now if it 
happens again.

> All theses popup box are iritating,   for debug message, you could use
> kdDebug instead.
>
I changed all of the "Debug messageboxes" to kdDebug now.

> I've also noted some memory leak by browsing the code:
> | Kopete::Message *newmsg = new Kopete::Message( msg.from(), msg.to(),
> |          msgbody, Kopete::Message::Internal, Kopete::Message::RichText );
> | newmsg->setManager( msg.manager() );
> | msg = *newm
>
> That's wrong and cause a memory leak.   Kopete::Message is not a class that
> should be used as pointer.  A correct solution would be
>
> | msg = Kopete::Message( msg.from(), msg.to(),
> |          msgbody, Kopete::Message::Internal, Kopete::Message::RichText );
> | msg.setManager( msg.manager() );
>

Yes... I already thought this could be a meory leak and tried to delete the 
original message (doesn't work). Didn't knew that I just can overwrite the 
Message this way. Thanks for the hint. I changed it now.

I will do some points of my ToDo list this weekend and post a new version.

Regards,
Michael
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to