Hello developers,
I normally do not get around much in user space code, let alone in a
monstrosity like KDE. However, a recent posting to the kernel mailing
list caught my attention, which I should like to direct towards you:
http://marc.theaimsgroup.com/?l=linux-kernel&m=116422885800590&w=2
One of the cited sources among the thousands was your code and I've
taken the liberty to address this issue and hope that this somewhat
cheap but interesting code analyzing technology can be further pursued
in the KDE project (which I'm an avid user of), among the probably
dozens of other static and dynamic code-related checks you guys already do.
The patch is against the current SVN head found at:
http://websvn.kde.org/trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp?rev=589132&view=markup
Please consider applying and best regards,
Roberto Nibali, ratz
--
echo
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc
--- jabbercontact.cpp 2006-11-24 11:07:46.000000000 +0100
+++ jabbercontact.cpp-new 2006-11-24 11:08:39.000000000 +0100
@@ -947,7 +947,7 @@
kDebug ( JABBER_DEBUG_GLOBAL ) << k_funcinfo << contactId () /*<< " - "
<<kdBacktrace()*/ << endl;
- if(!m_syncTimer);
+ if(!m_syncTimer)
{
m_syncTimer=new QTimer(this);
connect(m_syncTimer, SIGNAL(timeout()) , this ,
SLOT(slotDelayedSync()));
_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel
