Gi

Le dimanche 13 août 2006 23:35, Michel Hermier a écrit :
> SVN commit 572760 by hermier:
>
> Make Kopete::Contact also a child a Kopete::ContactListElement.

What is the interest of that ?

Kopete::ContactListElement (formerly KopetePluginDataObject) is a class to 
share the code XML saving code, and the PluginData stuff between 
KopeteMetaContact and KopeteGroup (and even KopeteAccount when it was still 
stored in XML)
Later, the possibility to add custom icon was added for group and metacontact.

I don't see a single reason to have Kopete::Contact inherit from this.

Kopete::Contact use the Kopete::Property system, and not plugin data.

anyway, since the XML code is now moved in the backed,  and the possibility to 
set icon for a metacontact is deprecated now we have photo, there is only the 
plugin data stuff left there.

I don't like the fact that the protocol store contact as pluginData instead of 
using appropriate element in the XML.  but now that's not a question anymore 
since we will move to akonadi[1]


[1] It is maybe time to write a mail to the kde-pim mailing list asking for 
our need.  but also define our need.

Attachment: pgpGpLt3R5jHO.pgp
Description: PGP signature

_______________________________________________
kopete-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to