Le samedi 22 juillet 2006 03:57, Michael D. Stemle, Jr. a écrit : > Okay, so I sent in a patch and got some feedback. All the changes > requested were pretty minor, and are listed below: Remove excessive debug > code > Use static_cast around iterator dereferences > Formatting changed to remain consistent with the remainder of the file.
Hi, thanks for your patch.
Sorry for the late reply, i was busy last week.
The idea is great and must be in the next Kopete. (trunk)
Some comments thought :
I don't think it's required to add stuff in libkopete for that.
- stealContactsFromMetaContact could be still be placed as a helper
function in the contactlist tree.
- I'd like to remove the whole KopeteStdAction. Just create your action
directly.
Please do the change, and I'll commit your patch. if you do'nt have a svn
account.
> As for #3, I noticed that some of files have the vim block in there
> somewhere. I also noticed that kdepim folks actually started making their
> codebase a little more friendly for emacs users (such as myself). For that
> purpose, I've attached to this the .emacs-dirvar file that I've used in all
> of the folders to this email. I'm not sure if there's a better way to do
> it or not. I have no interest in messing up formatting of code, and I know
> some folks are rather serious about making sure the files are using
> consistent formatting. Fair enough. I'll do what I can to respect that.
>
> Without further ado, the patch is attached to this message. No functional
> changes were made. Enjoy.
We use tab instead of space for indenting. please fix that too :-)
pgpPtiXqY09Kl.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
