Hi, My vote is for commit (both patches), since, JEP-0022 is deprecated and therefore we will not be correctly interpreting the protocol, which is a bug.
And, if we only partially implement the new JEP, then that's about the same as supporting an old version. That is, the new state(s) offered by JEP-0085 are part of the protocol now, and to not respond to the 'window closed' event of the protocol is less than a complete implementation. Lastly, it doesn't matter if we, as developers, view it as a feature. A user that's expecting it, and doesn't get it will call it a bug. ~linuxfood On Saturday 01 April 2006 14:14, Olivier Goffart wrote: > Hello. > > I'd like to commit chatstates_iris and maybe jabber_gone > I'm posting here in order to ask for review because it may be considered as > new feature. patches are quite small anyway. > > BACKGROUND: > Currently, Kopete uses JEP-0022 [1] for typing notification. Most of > ancient client implement it. > Anyway, new client now implement JEP-0085 [2] . Some client implement only > it (gtalk, libgaim based clients, ...) > > PATCHES: > the attached chatstates_iris.diff is a patch against libiris (in the 0.12 > branch) to implement the new jep on the old one. > I'd like to commit it, this is not really a new feature, since users may > think typing notification are broken. (we received already a bug report > [3]) > > The second patch (jabber_gone) is a patch to Kopete 0.12, that implement a > new feature provided by JEP-0085: the ability to know when the user closes > his window > This is a new feature, should I commit ? > > PSI: > the psi guys have also implemented the JEP-0085, but a bit differently: > (see the chatstates_psi.diff patch) > their way is more complex, but more low)level to the protocol itself. And > it require much ore change in the client. We probably should go that way > in KDE4 > (i only had their patch after having implemented it) > > > [1] http://www.jabber.org/jeps/jep-0022.html > [2] http://www.jabber.org/jeps/jep-0085.html > [3] https://bugs.kde.org/show_bug.cgi?id=121507 > > > PS: i wanted to also implement the jep-0183 , but it's too late, i must > have done that yesterday :-) .
pgplgz3zykL0E.pgp
Description: PGP signature
_______________________________________________ kopete-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kopete-devel
