A regexp '^0' in basket.tt is used to give the class "error" to null prices.
It is wrong, because it matches prices like "0.15". It should only match "0.00".
To test :
- apply the patch
- display a basket with an order with a price between 0 and 1 (like "0.50") and an order
with a price stricty null ("0.00")
- only the "0.00" price should be displayed in red
---
.../intranet-tmpl/prog/en/modules/acqui/basket.tt | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
index ccc97d5..0b3969f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
@@ -349,15 +349,15 @@
<p>[<a
href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% books_loo.ordernumber %]">Add
note</a>]</p>
[% END %]
</td>
- <td class="number gste [% IF books_loo.rrpgste.search('^0')
%]error[% END %]">[% books_loo.rrpgste %]</td>
- <td class="number gste [% IF books_loo.ecostgste.search('^0')
%]error[% END %]">[% books_loo.ecostgste %]</td>
- <td class="number gsti [% IF books_loo.rrpgsti.search('^0')
%]error[% END %]">[% books_loo.rrpgsti %]</td>
- <td class="number gsti [% IF books_loo.ecostgsti.search('^0')
%]error[% END %]">[% books_loo.ecostgsti %]</td>
- <td class="number [% IF books_loo.quantity.search('^0') %]error[%
END %]">[% books_loo.quantity %]</td>
- <td class="number gste [% IF books_loo.totalgste.search('^0')
%]error[% END %]">[% books_loo.totalgste %]</td>
- <td class="number gsti [% IF books_loo.totalgsti.search('^0')
%]error[% END %]">[% books_loo.totalgsti %]</td>
- <td class="number [% IF books_loo.gstgsti.search('^0') %]error[% END
%]">[% books_loo.gstgsti %]</td>
- <td class="number [% IF books_loo.gstvalue.search('^0') %]error[%
END %]">[% books_loo.gstvalue %]</td>
+ <td class="number gste [% IF books_loo.rrpgste.search('^0.00')
%]error[% END %]">[% books_loo.rrpgste %]</td>
+ <td class="number gste [% IF books_loo.ecostgste.search('^0.00')
%]error[% END %]">[% books_loo.ecostgste %]</td>
+ <td class="number gsti [% IF books_loo.rrpgsti.search('^0.00')
%]error[% END %]">[% books_loo.rrpgsti %]</td>
+ <td class="number gsti [% IF books_loo.ecostgsti.search('^0.00')
%]error[% END %]">[% books_loo.ecostgsti %]</td>
+ <td class="number [% IF books_loo.quantity.search('^0.00') %]error[%
END %]">[% books_loo.quantity %]</td>
+ <td class="number gste [% IF books_loo.totalgste.search('^0.00')
%]error[% END %]">[% books_loo.totalgste %]</td>
+ <td class="number gsti [% IF books_loo.totalgsti.search('^0.00')
%]error[% END %]">[% books_loo.totalgsti %]</td>
+ <td class="number [% IF books_loo.gstgsti.search('^0.00') %]error[%
END %]">[% books_loo.gstgsti %]</td>
+ <td class="number [% IF books_loo.gstvalue.search('^0.00') %]error[%
END %]">[% books_loo.gstvalue %]</td>
<td>[% books_loo.budget_name %]</td>
[% IF ( active ) %]
[% UNLESS ( closedate ) %]
--
1.7.9.5
--
Mathieu Saby
Service d'Informatique Documentaire
Service Commun de Documentation
Université Rennes 2
Téléphone : 02 99 14 12 65
Courriel : mathieu.s...@univ-rennes2.fr
_______________________________________________
Koha-patches mailing list
Koha-patches@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
