From: Ian Walls <[email protected]> Part one: followup to the original patch. The variable name for the URL itself was wrong, so despite getting the link to show up, the href was the catalog page itself, NOT the 856$u. Updating "MARCurl.MARCurl" to "MARCurl.MARCURL" fixes this issue.
To test: go to the OPAC, and see that the URL in the link is the same as the URL in the MARC Part two: this problem is present on the staff side, as well. This patch implements both parts of the fix (renaming "MARCurlS" to "MARCURLS" and "MARCurl.MARCurl" to "MARCurl.MARCURL") To test: go to the staff client, and check that a)URLs show up and b)they link to the URL in the MARC record Signed-off-by: Ian Walls <[email protected]> Signed-off-by: Nicole C. Engard <[email protected]> --- .../prog/en/modules/catalogue/detail.tt | 6 +++--- koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index 39c2cd3..fffe411 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -138,14 +138,14 @@ function verify_images() { [% IF ( pages ) %] [% END %][% pages %] [% IF ( illus ) %][% illus %][% END %] [% IF ( size ) %][% size %][% END %] </li> -[% IF ( MARCurlS ) %]<li> +[% IF ( MARCURLS ) %]<li> <strong>Online Resources:</strong> - <ul> [% FOREACH MARCurl IN MARCurlS %] + <ul> [% FOREACH MARCurl IN MARCURLS %] <li>[% IF ( MARCurl.part ) %][% MARCurl.part %] <br />[% END %] <!-- here you might do a tmpl_if name="toc" and use greybox or equivalent for table of contents --> - <a href="[% MARCurl.MARCurl %]" title="[% MARCurl.MARCurl %]">[% MARCurl.linktext %]</a> + <a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]">[% MARCurl.linktext %]</a> [% IF ( MARCurl.notes ) %]<ul>[% FOREACH note IN MARCurl.notes %]<li>[% note.note %]</li>[% END %]</ul>[% END %]</li> [% END %]</ul> </li> diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt index 534aeee..01a66a3 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt @@ -189,7 +189,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () { <br />[% END %] <!-- here you might do a tmpl_if name="toc" and use greybox or equivalent for table of contents --> - [% IF ( MARCurl.OPACurlOpenInNewWindow ) %]<a href="[% MARCurl.MARCurl %]" title="[% MARCurl.MARCurl %]" target="_blank">[% ELSE %]<a href="[% MARCurl.MARCurl %]" title="[% MARCurl.MARCurl %]">[% END %] + [% IF ( MARCurl.OPACurlOpenInNewWindow ) %]<a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]" target="_blank">[% ELSE %]<a href="[% MARCurl.MARCURL %]" title="[% MARCurl.MARCURL %]">[% END %] [% MARCurl.linktext %]</a> [% IF ( MARCurl.notes ) %]<ul>[% FOREACH note IN MARCurl.notes %]<li>[% note.note %]</li>[% END %]</ul>[% END %]</li> -- 1.7.2.3 _______________________________________________ Koha-patches mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
