I have mixed opinions about this. On the one hand it seems reasonable, and on the other it seems unnecessary. There are only three places that call AddMember: memberentry, import_borrowers and Auth_with_ldap. In fact, I recently coded a feature for a client so that import_borrowers has a runtime option on how to handle extended attributes (overwrite all, or preserve -- like other fields). Making a separate call for the attributes was not a serious problem. LDAP currently can't handle extended attributes, so there's no benefit there.
This overwrite/preserve issue would need to be addressed in the refactor also, to ensure that we know for sure what behavior is expected when ModMember (in particular) is called. In the case where only extended attributes are being edited, it certainly is logically simpler to have a call just for that, though that doesn't necessarily preclude the kind of integration you propose. --Joe On Mon, Mar 9, 2009 at 4:39 PM, LAURENT Henri-Damien < henridam...@koha-fr.org> wrote: > I would like to propose that C4::Members::Attributes could be more > tightly integrated into C4::Members so that > AddMember(%member) or ModMember,... or whatever... > would also call Attributes add. > This would allow ppl to have only one function call to add a Member and > not many little functions to call. > > And would eventually be more friendly for unifying calls to functions. > Does that sound a good idea ? > I could send a patch tomorrow about that. > > Comments welcome. > > -- > Henri-Damien LAURENT
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
