> Trying to find out what the difference was between > $itm->{'notforloan'} and $itm->{'itemnotforloan'} I checked > GetItemsInfo() in Items.pm. GetItemsInfo() SELECTs both "items.*" and > "items.notforloan as itemnotforloan." > > So $itm->{'notforloan'} and $itm->{'itemnotforloan'} are the same thing?
When I brought this up on IRC yesterday Galen pointed out that the purpose of selecting "items.notforloan as itemnotforloan" would be to differentiate from itemtypes.notforloan. That makes sense, except that in the case of GetItemsInfo() itemtypes.notforloan isn't being pulled. So, when opac-reserve.pl says: if (!$itm->{'notforloan'} && !($itm->{'itemnotforloan'} > 0)){ $forloan=1; } Is the intention that $item->{'notforloan'} be the value of itemtypes.notforloan? -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel