I like this better actually. So here is another patch using this
method.
What say y'all?
On Thu, 2009-02-12 at 17:02 -0500, Danny Bouman wrote:
> Owen mentioned that he sent a patch for this issue a while back and I
> just wanted to pass this along.
>
> http://lists.koha.org/pipermail/koha-patches/2008-November/002150.html
>
> It is a different method then has been discussed, but should still do
> the trick.
>
> --
> Danny Bouman
> Web Programmer
> Howard County Central Library
> 10375 Little Patuxent Parkway
> Columbia, MD 21044
> 410.313.7924
>
>
> ----- Original Message -----
> From: Michael Hafen <mdha...@tech.washk12.org>
> To: <koha-devel@lists.koha.org>
> Cc:
> Date: Thursday, February 12 2009 03:47 PM
> Subject: Re: [Koha-devel] Item Type Images have various sizes
> Here's a draft of the patch. Ignore the lack of updatedatabase
> stuff.
> Is there anything else that should be changed here?
>
> Thanks.
>
> On Thu, 2009-02-12 at 11:37 -0500, Galen Charlton wrote:
> > Hi,
> >
> > On Thu, Feb 12, 2009 at 11:25 AM, Michael Hafen
> > <mdha...@tech.washk12.org> wrote:
> > > My idea in the beginning was something to this effect. I
> don't really
> > > feel like trying to figure out authorized values right
> now, but I will
> > > look to see if iconsets are kept in the database somewhere
> other than
> > > that.
> >
> > Iconsets are not stored in the database - they're just
> directories in
> > koha-tmpl/opac-tmpl/prog/itemtypeimg or
> > ./koha-tmpl/intranet-tmpl/prog/img/itemtypeimg, so there
> currently
> > isn't a place to stick the maximum dimensions of a iconset.
> However,
> > both the authorised_values and itemtypes have an imageurl
> column
> > pointing to the icon associated with item type or authval,
> so one
> > possibility is adding imageheight and imagewidth columns to
> those
> > tables.
> >
> > Regards,
> >
> > Galen
> --
> Michael Hafen
> Systems Analyst and Programmer
> Washington County School District
> Utah, USA
>
> for Koha checkout
> http://koha-dev.washk12.org
> or
> git://koha-dev.washk12.org/koha
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-devel
--
Michael Hafen
Systems Analyst and Programmer
Washington County School District
Utah, USA
for Koha checkout
http://koha-dev.washk12.org
or
git://koha-dev.washk12.org/koha
>From 6a59f358558c95c8b8788cc44fb19a501a976471 Mon Sep 17 00:00:00 2001
From: Michael Hafen <mdha...@tech.washk12.org>
Date: Fri, 13 Feb 2009 15:48:37 -0700
Subject: [PATCH] bug itemtype icons interfere with location text
Content-Type: text/plain; charset="utf-8"
Thanks to Owen for this.
This changes the itemtype icons from css backgrounds to images. Also
there is a little css tweaking to compensate for some other things taken
out from that area - like margin and padding declarations.
---
.../intranet-tmpl/prog/en/css/staff-global.css | 22 ++++++++++++++++++++
.../prog/en/modules/catalogue/results.tmpl | 10 ++++----
2 files changed, 27 insertions(+), 5 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
index 18199c9..03157f5 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
@@ -1274,7 +1274,29 @@ overflow : hidden;
}
#searchresults ul li {
+ font-size : 90%;
list-style : url(../../img/item-bullet.gif);
+ padding : .2em 0;
+}
+
+#searchresults span.status {
+ clear : left;
+ color : #900;
+ display : block;
+}
+
+#searchresults span.unavailable {
+ clear : left;
+ display : block;
+}
+
+#searchresults .availability strong {
+ display : block;
+}
+
+#searchresults ul li img {
+ float : left;
+ margin : 3px 5px 3px -5px;
}
#searchresults table td {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tmpl
index 3609e26..0c18780 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tmpl
@@ -330,7 +330,7 @@ $(window).load(function() {
<ul>
<!-- TMPL_LOOP NAME="available_items_loop" -->
- <!-- TMPL_IF NAME="noItemTypeImages" --><li><!-- TMPL_ELSE --><!-- TMPL_IF NAME="item-level_itypes" --><!-- TMPL_IF name="imageurl" --><li style=" list-style: none; list-style-type: none; background-image: url(<!-- TMPL_VAR name="imageurl" -->); background-repeat: no-repeat; background-position: 0 50%; padding: 3px 0 3px 30px; margin: .4em 0; " title="<!-- TMPL_VAR name="description" -->"><!-- TMPL_ELSE --><li><!-- /TMPL_IF --><!-- TMPL_ELSE --><li><!-- /TMPL_IF --><!-- /TMPL_IF -->
+ <!-- TMPL_IF NAME="noItemTypeImages" --><li><!-- TMPL_ELSE --><!-- TMPL_IF NAME="item-level_itypes" --><!-- TMPL_IF name="imageurl" --><li style="list-style: none; list-style-type: none;"><img src="<!-- TMPL_VAR name="imageurl" -->" title="<!-- TMPL_VAR NAME="description" -->"/><!-- TMPL_ELSE --><li><!-- /TMPL_IF --><!-- TMPL_ELSE --><li><!-- /TMPL_IF --><!-- /TMPL_IF -->
<!-- TMPL_IF NAME="branchname" --><!-- TMPL_VAR NAME="branchname" --><!-- /TMPL_IF -->
<!-- TMPL_IF NAME="location" --><!-- TMPL_VAR NAME="location" --><!-- /TMPL_IF -->
<!-- TMPL_IF NAME="itemcallnumber" -->[<a href="/cgi-bin/koha/catalogue/search.pl?q=callnum:<!-- TMPL_VAR NAME="itemcallnumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="itemcallnumber" --></a>]<!-- /TMPL_IF -->
@@ -341,12 +341,12 @@ $(window).load(function() {
<!-- /TMPL_IF -->
<!-- TMPL_IF NAME="onloan_items_loop" -->
- <!-- TMPL_IF NAME="onloancount" --><!-- TMPL_VAR NAME="onloancount" --><!-- /TMPL_IF --> on loan:
+ <span class="status"><!-- TMPL_IF NAME="onloancount" --><!-- TMPL_VAR NAME="onloancount" --><!-- /TMPL_IF --> on loan:</span>
<ul>
<!-- TMPL_LOOP NAME="onloan_items_loop" -->
<!-- TMPL_IF NAME="noItemTypeImages" --><li><!-- TMPL_ELSE --><!-- TMPL_IF NAME="item-level_itypes" -->
<!-- TMPL_IF name="imageurl" -->
- <li style=" list-style: none; list-style-type: none; background-image: url(<!-- TMPL_VAR name=imageurl -->); background-repeat: no-repeat; background-position: 0 50%; padding: 3px 0 3px 30px; margin: .4em 0;" title="<!-- TMPL_VAR name="description" -->">
+ <li style="list-style: none; list-style-type: none;"><img src="<!-- TMPL_VAR name=imageurl -->" title="<!-- TMPL_VAR name="description" -->"/>
<!-- TMPL_ELSE --><li><!-- /TMPL_IF -->
<!-- TMPL_ELSE --><li><!-- /TMPL_IF --><!-- /TMPL_IF -->
@@ -358,12 +358,12 @@ $(window).load(function() {
<!-- /TMPL_IF -->
<!-- TMPL_IF NAME="other_items_loop" -->
- <!-- TMPL_IF NAME="othercount" --><!-- TMPL_VAR NAME="othercount" --><!-- /TMPL_IF --> unavailable:
+ <span class="unavailable"><!-- TMPL_IF NAME="othercount" --><!-- TMPL_VAR NAME="othercount" --><!-- /TMPL_IF --> unavailable:</span>
<ul>
<!-- TMPL_LOOP NAME="other_items_loop" -->
<!-- TMPL_IF NAME="noItemTypeImages" --><li><!-- TMPL_ELSE --><!-- TMPL_IF NAME="item-level_itypes" -->
<!-- TMPL_IF name="imageurl" -->
- <li style="list-style: none; list-style-type: none; background-image: url(<!-- TMPL_VAR name="imageurl" -->); background-repeat: no-repeat; background-position: 0 50%; padding: 3px 0 3px 30px; margin: .4em 0;" title="<!-- TMPL_VAR name="description" -->">
+ <li style="list-style: none; list-style-type: none;"><img src="<!-- TMPL_VAR name="imageurl" -->" title="<!-- TMPL_VAR name="description" -->"/>
<!-- TMPL_ELSE --><li><!-- /TMPL_IF -->
<!-- TMPL_ELSE --><li><!-- /TMPL_IF --><!-- /TMPL_IF -->
--
1.5.6.3
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha.org
http://lists.koha.org/mailman/listinfo/koha-devel
