To get it working, I still needed (on a D11 container):
apt-get install nodejs npm
npm install -g yarn
yarn install
npm install -E
yarn build_js
I checked npm audit giving lots of warnings. In summary, 61 vulnerabilities (37
moderate, 17 high, 7 critical).
Should we recommend to fix those too?
yarn build_js also gives warnings:
WARNING in asset size limit: The following asset(s) exceed the recommended size
limit (244 KiB).
This can impact web performance.
Assets:
main.js (1.44 MiB)
Similar one for entrypoint size limit
And WARNING in webpack performance recommendations.
In git I notice:
Changes not staged for commit:
modified: package.json
modified: yarn.lock
Untracked files:
package-lock.json
How should we handle those?
Marcel
________________________________
Van: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Verzonden: donderdag 10 november 2022 08:50
Aan: Jonathan Druart <jonathan.dru...@gmail.com>
CC: Koha Devel <koha-devel@lists.koha-community.org>
Onderwerp: Re: [Koha-devel] ERM - workflow change
00h00m00s 0/0: : ERROR: [Errno 2] No such file or directory: 'build_js'
________________________________
Van: Jonathan Druart <jonathan.dru...@gmail.com>
Verzonden: donderdag 10 november 2022 08:39
Aan: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
CC: Koha Devel <koha-devel@lists.koha-community.org>
Onderwerp: Re: [Koha-devel] ERM - workflow change
Run the yarn commands at the root of the Koha src dir.
What's the output of `yarn build_js`?
Le jeu. 10 nov. 2022 à 08:15, Marcel de Rooy
<m.de.r...@rijksmuseum.nl> a écrit :
>
> Does this need some envvar for a path to the Koha's package.json or so ?
> When I ran yarn build_js, I did not have any valuable results.
>
> ________________________________
> Van: Koha-devel <koha-devel-boun...@lists.koha-community.org> namens
> Renvoize, Martin <martin.renvo...@ptfs-europe.com>
> Verzonden: woensdag 9 november 2022 18:33
> Aan: Koha Devel <koha-devel@lists.koha-community.org>
> Onderwerp: Re: [Koha-devel] ERM - workflow change
>
> To get up and running fast in k-t-d,
>
> kshell
> $ kshell
> k$ yarn install
> k$ yarn build_js
>
>
>
> On Wed, 9 Nov 2022, 3:54 pm Tomas Cohen Arazi, <tomasco...@gmail.com> wrote:
>
> Hi all, we pushed ERM but didn't communicate some decisions made:
>
> - For running the ERM component (and in the future any other Vue-driven
> thing) a build step needs to happen. Either:
>
> $ yarn build_js
>
> or (the dev-oriented version):
>
> $ yarn watch_js
>
> - We could've gone 'the SCSS' way, in which the RM(aint) compiles the thing
> and pushes to Git along with the changes. But we decided it would have an
> impact on the size of the repository pretty fast. So for now, the decision is
> we will do it at release time. This is also common practice on Vue projects.
>
> - We could add the build as part of the 'reset_all' command KTD users are
> familiar with. TBD
>
> - Yes, now that running Koha requires a build step, we could just add SCSS
> there, that's to be discussed early next cycle.
>
> - We need a way to pre-bundle all the dependencies in KTD, so people can fire
> up KTD while being offline. Agustín is wrapping up a proposal for this. TBD
>
> Please share your thoughts, and sorry for not communicating this earlier.
>
> --
> Tomás Cohen Arazi
> Theke Solutions
> (https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftheke.io%2F&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=sBmz22VOwY0biVGf3Bz%2F3u407ibEpukVmHX1onqueGg%3D&reserved=0)
> ✆ +54 9351 3513384
> GPG: B2F3C15F
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.koha-community.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fkoha-devel&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=SDeZlavZ9YHsJ6LDg1kYRcklQ%2Fxz4E8ajU%2Bqr9mwFb0%3D&reserved=0
> website :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.koha-community.org%2F&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YVpdes%2FXmgWMdtmQPCujEjWXMCflidGogAePFatC%2F2c%3D&reserved=0
> git :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.koha-community.org%2F&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=h%2BxoF1OKpS34bSETWXzDVY30JXJVlHFo98vTiYrEZ0g%3D&reserved=0
> bugs :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2F&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xW2x6YHpsYF%2F5AonyGcmTKJgkFQNHYTQwJeQJ%2FiYjKI%3D&reserved=0
>
> _______________________________________________
> Koha-devel mailing list
> Koha-devel@lists.koha-community.org
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.koha-community.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fkoha-devel&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=SDeZlavZ9YHsJ6LDg1kYRcklQ%2Fxz4E8ajU%2Bqr9mwFb0%3D&reserved=0
> website :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.koha-community.org%2F&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YVpdes%2FXmgWMdtmQPCujEjWXMCflidGogAePFatC%2F2c%3D&reserved=0
> git :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.koha-community.org%2F&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=h%2BxoF1OKpS34bSETWXzDVY30JXJVlHFo98vTiYrEZ0g%3D&reserved=0
> bugs :
> https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-community.org%2F&data=05%7C01%7CM.de.Rooy%40rijksmuseum.nl%7C485d820262324850f10f08dac2eeb28f%7C635b05eb66c748e1a94fb4b05a1b058b%7C0%7C0%7C638036627696763451%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xW2x6YHpsYF%2F5AonyGcmTKJgkFQNHYTQwJeQJ%2FiYjKI%3D&reserved=0
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : https://www.koha-community.org/
git : https://git.koha-community.org/
bugs : https://bugs.koha-community.org/
