Hi Owen,

But why was the OPAC designed to have 40 pixels of padding on either side of 
the main content? Why not just be full width? I notice when I'm on my phone 
that it doesn't have the padding, which leads to inconsistent presentation 
between desktop and mobile (without any customization). 

I should've phrased that better. What I meant was that some of the changes in 
the media queries seem inconsistent. It shouldn’t be necessary to change the 
padding and margins for a header/banner in 10 different media queries when 
we're using auto width already. It seems unnecessarily complicated for a simple 
thing. 

I notice Athens Country Public Library doesn't have any custom header or 
footer, so I can see how the padding looks OK. And I know it is tough to get 
everything right for all mobiles. On my phone, the ACPL search page actually 
crops the MyACPL logo and the custom search links run off the side of the page. 

If the answer is "it has 40 pixels just because", that's fine. I was just 
curious. I think I just miss the version of Koha where it was easier to add 
custom headers, but I'll figure something out. 

David Cook
Software Engineer
Prosentient Systems
Suite 7.03
6a Glen St
Milsons Point NSW 2061
Australia

Office: 02 9212 0899
Online: 02 8005 0595

-----Original Message-----
From: Owen Leonard <oleon...@myacpl.org> 
Sent: Wednesday, 16 December 2020 11:22 PM
To: David Cook <dc...@prosentient.com.au>
Cc: Koha Devel <koha-devel@lists.koha-community.org>
Subject: Re: Why does #wrap have padding?

> Does anyone know why #wrap in 
> koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss has padding-left: 40px and 
> padding-right: 40px?

Because the OPAC was designed to have 40 pixels of padding on either side of 
the main content.

> It makes adding full-width headers/footers impossible without tricks and 
> compensations for changes to the padding with the responsive media queries.

All CSS customizations require tricks and compensations to override!

  -- Owen

--
Web Developer
Athens County Public Libraries
(740) 737-6006
https://www.myacpl.org


_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to