Hi Joonas, I've just taken a look at comment 59 but I'm not sure why you decided to rescue it based on that comment.
I'm happy to leave some feedback on the bug report. I'll do that quickly now. Cheers, David Cook Software Engineer Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Joonas Kylmälä <joonas.kylm...@helsinki.fi> Sent: Tuesday, 8 September 2020 5:10 PM To: dc...@prosentient.com.au Cc: 'koha-devel' <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] Request for sign-off: component part records feature (Bug 11175) Hi, thanks for taking a look! There is already some discussion in the bug report about Elasticsearch and about the backend implementation but that is from 2018 and earlier so I'm not sure it is up to date and is that's why you have concerns about the approach? Please let us know in the bug report comments, and feel free to mark "In discussion" if needed. Also please see comment 59 for why I decided to rescue this and whether it is okay in your opinion. Joonas On 08/09/2020 04:27, dc...@prosentient.com.au wrote: > Hi Joonas, > > I've taken another look at the report (my last look was in 2014), but I don't > think that this is the right approach. It also doesn't take into account > Elasticsearch. > > I might be wrong, but I don't imagine that this would pass QA or be pushed to > master. I'm actually tempted to mark it as "In Discussion" to be honest. > > David Cook > Software Engineer > Prosentient Systems > 72/330 Wattle St > Ultimo, NSW 2007 > Australia > > Office: 02 9212 0899 > Online: 02 8005 0595 -- Joonas Kylmälä Tietojärjestelmäasiantuntija Kansalliskirjasto Kirjastoverkkopalvelut PL 15 (Unioninkatu 36) 00014 Helsingin yliopisto _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
