Hi Tomas,

I can see the benefits of a per-library, per-itemtype, per-category configuration table, but SMTP and Z39.50 servers do not seem to be the best example for that : "per-itemtype SMTP servers" does not make sense at all, and why would someone need per-library Z39.50 servers ?
Do you have other examples in mind ?

Will the per-category setting rely on the category of the logged-in user or the category of the user being worked on (patron checking out an item for instance) ? Will it depend on the setting itself (some settings rely on the logged-in user, some other settings rely on the user being worked on) ? Will it depend on another setting (like item-level_itypes syspref) ? Will that other setting be configurable per-library ? ... I'm afraid we will end up with a "configuration hell", even worse than what we already have with global system preferences. At least it should be very clear what each per-thing mean, and we should be really careful to not over-complicate configuration.
In this particular example, a `smtp_servers` table seems a lot more simple

Le 03/08/2020 à 19:59, Tomas Cohen Arazi a écrit :
TL;DR;
This email is for getting some feedback about a new table I'm proposing to add that implements a pattern I'm seeing more and more often as required: global, and per-library, per-item type and per-category settings. It can be easily extended with new constraints as well.

Hi all, I wanted to highlight bug 26129 [1] which proposes to add a new table, for storing configuration entries. It differs from the systempreferences table basically on the ability to set values with per-library, per-item type and per-category basis, as well as default catch-all.

It is the result of noticing that the smtp_servers table I was going to add on bug 22343 [2], could be easily generalized and could become useful.

If someone is willing to do it, we could migrate systempreferences into this new table, but that definitely deserves more thinking. The SMTP configuration page won't live in the sysprefs page, and so a way to differentiate them could be added.

One sample use of this configurations table, could be moving z39.50 servers there.

[1] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26129> [2] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343>

--
Tomás Cohen Arazi
Theke Solutions (http://theke.io <http://theke.io/>)
✆ +54 9351 3513384
GPG: B2F3C15F

_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


--
Julian Maurice
BibLibre
_______________________________________________
Koha-devel mailing list
Koha-devel@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to