You are looking at a POC, that doesn't have the endpoints it need to hit
against, so it has some sample values in plain english. But a real
implementation would of course use the usual _("blah") stuff, and have the
strings defined in a translatable file/directory.El mar., 20 sept. 2016 a las 21:17, David Cook (<dc...@prosentient.com.au>) escribió: > I think Katrin and I both are probably referring to this file: > https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17297&attachment=55545 > > > > It embeds HTML and hardcoded strings in the .js file. It would be great to > see a translateable version. > > > > David Cook > > Systems Librarian > > Prosentient Systems > > 72/330 Wattle St > > Ultimo, NSW 2007 > > Australia > > > > Office: 02 9212 0899 > > Direct: 02 8005 0595 > > > > *From:* koha-devel-boun...@lists.koha-community.org [mailto: > koha-devel-boun...@lists.koha-community.org] *On Behalf Of *Kyle Hall > *Sent:* Tuesday, 20 September 2016 11:22 PM > *To:* Katrin <katrin.fischer...@web.de> > *Cc:* Koha Devel <koha-devel@lists.koha-community.org> > > > *Subject:* Re: [Koha-devel] To React or not to React > > > > Katrin I'm not quite sure what you mean. When I wrote we translate these > files the same way we do other js files, I meant that we define the strings > to be translated either in the script template file or in an include file > and then only use the var storing the string in the js file. React is just > Javascript and what we've been doing should work absolutely fine. I'll > update my POC to be translatable when I get some time! > > > > If this is not what you meant Katrin, please let me know! > > > > Kyle > > > > <https://secure2.convio.net/cffh/site/Donation2?df_id=1395&FR_ID=4715&PROXY_ID=2706639&PROXY_TYPE=20&1395.donation=form1&s_src=CHORUS&s_subsrc=CHAADOEB> > > > > http://www.kylehall.info > ByWater Solutions ( http://bywatersolutions.com ) > Meadville Public Library ( http://www.meadvillelibrary.org ) > Crawford County Federated Library System ( http://www.ccfls.org ) > > > > On Mon, Sep 19, 2016 at 11:51 PM, Katrin <katrin.fischer...@web.de> wrote: > > > Also, how would this React POC go in terms of translations? > > > > React is just Javascript, and is translated the same way translate all our > other js files. > > We don't translate js files at the moment - which may be debatable. One > benefit at the moment of keeping the strings only in the templates is that > we don't copy the js files as we do with the template files. I think this > should be solvable, but it's something to keep in mind. > > > > > David Cook > Systems Librarian > Prosentient Systems > 72/330 Wattle St > Ultimo, NSW 2007 > Australia > > Office: 02 9212 0899 > Direct: 02 8005 0595 > > > > > -----Original Message----- > > From: koha-devel-boun...@lists.koha-community.org [mailto:koha-devel- > > boun...@lists.koha-community.org] On Behalf Of Owen Leonard > > Sent: Monday, 19 September 2016 11:33 PM > > To: Koha Devel <koha-devel@lists.koha-community.org> > > Subject: Re: [Koha-devel] To React or not to React > > > > > Another thing is that you need nodejs to compile it so is another > > > thing to throw on the stack. > > > > Isn't this the kind of dependency requirement that killed my request to > > introduce a front-end build tool like Grunt or Gulp? > > > > -- Owen > > > > -- > > Web Developer > > Athens County Public Libraries > > http://www.myacpl.org > > _______________________________________________ > > Koha-devel mailing list > > Koha-devel@lists.koha-community.org > > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > > website : http://www.koha-community.org/ git : http://git.koha- > > community.org/ bugs : http://bugs.koha-community.org/ > > > > > > _______________________________________________ > > Koha-devel mailing list > > Koha-devel@lists.koha-community.org > > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > > website : http://www.koha-community.org/ > > git : http://git.koha-community.org/ > > bugs : http://bugs.koha-community.org/ > > > > > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ > > > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha-community.org > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
