I think Tomas is going to add it to the agenda, as it corresponds with many other rules, especially those relating to object oriented code and unit tests.
Yes, I imagine there should be a rule for being careful with the scoping of variables as well, especially in regard to Plack (and mod_perl). David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007 From: Marcel de Rooy [mailto:m.de.r...@rijksmuseum.nl] Sent: Tuesday, 29 September 2015 7:34 PM To: David Cook <dc...@prosentient.com.au>; koha-devel@lists.koha-community.org Subject: RE: [Koha-devel] Add rule for no subroutines in PL scripts > I also noticed there's no rule forbidding subroutine definitions in PL scripts. I thought that we had a rule against > that as well. We don't have it. I would rather not have it too. There is a problem with Plack if you define lexical variables at top level and refer to them in the subroutines. Should be a rule for that?
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
