On Fri, Dec 16, 2011 at 10:12 PM, Chris Nighswonger < cnighswon...@foundations.edu> wrote:
> Hi Paul, > > On Fri, Dec 16, 2011 at 7:09 PM, Paul <pau...@aandc.org> wrote: > >> Lines 3006-3008 of biblio.pm called from additem.pl: >> >> # get title of the record (to store the 10 first letters with the >> index) >> my ( $titletag, $titlesubfield ) = GetMarcFromKohaField( >> 'biblio.title', '' ); # FIXME: should be GetFrameworkCode($**biblionumber) >> ?? >> $title = lc( $record->subfield( $titletag, $titlesubfield ) ); >> >> Before I start looking elsewhere, can someone kindly help me with the use >> of FIXME comments? >> > > FIXME's are notes by devs generally flagging code which works, but > could/should be factored differently, etc. > > This particular FIXME was added by commit > 6b9b778b1bc09eeb7d6e982a6fd5420b2209a641 authored by Joe Atzberger. I've > not dug into this far enough to know why he thought that GetFrameworkCode > might be the better function to use here. If he sees this thread, maybe he > can comment. However, I think its safe to say that the error you are > experiencing is not related to this FIXME. > Based on the commit message it looks like Joe was thinking that the second argument passed to GetMarcFromKohaField might should be populated with the results of GetFrameworkCode($biblionumber). In any case, it is still more likely to be corrupted data than the empty framework parameter passed to GetMarcFromKohaField that is causing your error. Kind Regards, Chris
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
