I favor the atomicupdate approach. (Makes testing the db change easier too.) In that case we could do something similar for updating the pref files in 5 to 10 language folders. These files have the same "not apply"-problem. With a few lines of code the RM could move new INSERT statements for prefs from atomicupdate to the pref folders too. Only a convention for naming the db and pref updates would be welcome.
Marcel -----Oorspronkelijk bericht----- Van: [email protected] [mailto:[email protected]] Namens Paul Poulain Verzonden: maandag 23 mei 2011 14:17 Aan: [email protected] Onderwerp: [Koha-devel] patches with DB change, workflow Hi all, I think there are some things unclear (at least for me ;-) ) about submitting bugs with DB changes. We said various things, I don't know which one is the correct one. * http://wiki.koha-community.org/wiki/Tutorial_for_Updating_Database_Files is the wiki page about this * we spoke of using XXXX in updatedatabase.pl to have te RM pick the right number when needed. * We also spoke of using atomicupdate, and let the RM append to updatedatabase when applying to master. What I see is that updatedatabase.pl changes a lot, making patches including them "does not apply" quite quickly. I'm wondering if it would not be easier to have "atomicupdate" and kohastructure.sql, the RM moving from atomicupdate to updatedatabase when applying. I think it would be easier to sign-off -just run atomicupdate attached to the bug- too. I already have encountered the problem twice today (I work on bugzilla). Your opinion ? -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08 _______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ _______________________________________________ Koha-devel mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
