https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43552
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Martin Renvoize (ashimema) <[email protected]> --- Thanks Pedro, good catch. The cause is in the single-dash shim of Koha::Script->describe_options (bug 43557): it rewrote -long as --long, but did not know the negated form of a negatable option such as send!, so -nosend was left alone and parsed as a bundle of one-character flags, hence 'Unknown option: n'. The new follow-up patch makes the shim accept -no<name> and -no-<name> for negatable options, rewriting them as --no-<name> with the same deprecation warning. A prefix does not resolve to a negated form, and the negated form of an option that is not negatable is still an error. It touches Koha::Script, so the other converted scripts benefit too. Tests added to t/Koha/Script.t; they fail without the change. I checked the script itself: 'gather_print_notices.pl /tmp -nosend', '-split -html -nosend' and '-csv -letter_code=X -nosend' all run again, with the deprecation warning, and --nosend runs without one. Both patches are re-attached, rebased on current main, with the signed-off-by lines kept. Setting back to Signed Off for another look. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
