https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30221

--- Comment #65 from Arthur Suzuki <[email protected]> ---
Created attachment 210235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210235&action=edit
Bug 30221: (QA follow-up) Remove TT tags from script blocks and tidy OPAC
templates

Move TT control structures ([% IF %], [% FOREACH %], [% END %]) out of
<script> blocks. Conditions are now defined as JS variables in a separate
<script> block, and column visibility is adjusted with plain JavaScript
if statements and a hide_column() helper.

- check-thead-tt-tags.t: remove the remaining conditional TT tags from
  the theads of the configurable OPAC tables (checkoutst, overduest,
  holdst, table_holdshistory). Preference-based columns (jacket image,
  links, checkout notes, hold group) are now always rendered and hidden
  client-side, via the 'hidden' class or hide_column(), like the other
  columns.
- Rename the opac_user_relative_issues_table table id to
  opac-user-relative-issues-table so that it matches the HTML table id,
  as required by check-thead-tt-tags.t and by tables_settings.get() at
  runtime (the settings were not applied to that table before).
- Keep opac-readingrecord.tt tidy (tt_tidy.t).
- opac-user.tt: add the missing checkout_branch th to the overduest
  thead (the tbody already had the checkout_branch td, causing a
  column count mismatch)
- opac-holdshistory.tt: use data-colname="library" to match the
  columns_settings.yml entry for table_holdshistory

Assisted-by: Mistral Vibe <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to