https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33260
--- Comment #659 from Andrew Fuerste-Henry <[email protected]> --- Created attachment 209969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209969&action=edit Bug 33260: (QA follow-up) Make converting to print clearer when it cannot work * Do not offer to convert notices when there is no CONVERTED_TO_PRINT notice, and when asked to anyway say that the notice does not exist and where to create it, instead of the notice could not be converted. * When the CONVERTED_TO_PRINT notice has an error, such as a missing [% END %] or an unknown variable, say so, and put the error in the error log. The notice that was to be converted is not changed. * Link the two notices, in the delivery note of each, which show 'Converted to print notice 123' and 'Converted from notice 122' on the notices management page and the Notices tab of the patron. To test: 1. Apply the patches, enable NoticesManagement 2. Queue a sent email notice for a patron, and convert it to print on the patron's Notices tab => The delivery note of the original says it was converted to the print notice, and that of the print notice says it was converted from the original 3. In Tools > Notices and slips, edit the CONVERTED_TO_PRINT notice (Patrons module, print) and add [% IF 1 %] without closing it. Try to convert another notice => It says the notice has an error, which is in the plack-intranet-error.log 4. Delete the CONVERTED_TO_PRINT notice => There are no Convert to print buttons. Going to the Notices tab with ?conversion=no_template says what is missing 5. prove t/db_dependent/Koha/Notice/Message.t Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Signed-off-by: Andrew Fuerste Henry <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
