https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43231

Martin Renvoize (ashimema) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #8 from Martin Renvoize (ashimema) 
<[email protected]> ---
Replying to the request for more comprehensive test instructions (comments 3, 5
and 6): I've rewritten the test plan in the commit message and re-attached the
patch. The code is unchanged.

I worked through the new steps from scratch on a KTD with Elasticsearch 8 to
make sure they hold up:
- On unpatched main, the upgrade stops at 25.12.00.059 with the reported
'mapper [local-number] cannot be changed from type [integer] to [text]' error,
exits with status 1, and nothing after that revision is applied.
- With the patch, the same state prints the warning and carries on: the later
50 or so revisions are applied and the Version ends up current.
- The mappings page then shows "Index 'koha_kohadev' needs to be recreated.",
and running misc/search_tools/rebuild_elasticsearch.pl -r -b makes the warning
go away.

Two things that were probably tripping people up in the old plan:
- Step 1 said to PUT an integer mapping on the existing index, but
Elasticsearch won't let you change it in place, and the problem is really a
mismatch between the index (integer) and what update_mappings builds from the
database (text). The new plan builds the index first and then changes the
database's type for local-number, which reproduces the failure reliably.
- The Version preference is stored without dots (25.12.00.058 is 25.1200058),
so 'roll the DB version back' wasn't something you could just type. The new
plan has the exact SQL to paste.

David N, if you're still keen, the steps should now be copy and paste. Thanks
both for pushing on this. Setting the status back to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to