https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43380
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize (ashimema) <[email protected]> --- QA review (Martin Renvoize) Reviewed the patch for regressions, code quality, Koha standards, security and performance. No blockers found. The fix is correct: itiva is skipped when TalkingTech_itiva_outbound.pl will generate the notice (pref enabled and patron has a phone), and falls back to a print notice otherwise. This also removes the dependence on hash ordering in the transports loop, and the case where an itiva message was queued that nothing would ever send. QA follow-up: added tests to t/db_dependent/Reserves.t covering itiva handled by the cron (no print, nothing queued), no phone number (print fallback) and TalkingTechItivaPhoneNotification disabled (print fallback). The new tests fail without the fix and pass with it. Reserves.t passes in full and koha-qa has been run. Out of scope, to be filed as a separate bug depending on this one: Koha::Patron::queue_notice has the same itiva check without the phone test, and the itiva cron emits rows with a blank phone number. Note: the previous attachment was obsoleted because the patches were re-attached with sign-off lines added. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
