https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43785

--- Comment #3 from Martin Renvoize (ashimema) 
<[email protected]> ---
QA: Scripts are happy, code reviewed.

Reviewed the patch (1 commit, 2 template files):
- Both 2FA code inputs are covered: the staff login field (otp_token, auth.tt)
and the setup PIN field (pin_code, auth-two-factor.inc). No other 2FA code
input exists in koha-tmpl (OPAC has none).
- The field-level autocomplete="one-time-code" overrides the form-level
autocomplete="off" from Bug 33253; the username and password fields keep
autocomplete="off", so that behaviour is unchanged.
- inputmode="numeric" is appropriate for TOTP PINs and only affects the mobile
keyboard; the input remains type="text".
- No escaping, CSRF or permission changes; no security impact.
- Commit message is clear, subject correctly prefixed, test plan thorough.

No regressions found. Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to