https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605
--- Comment #25 from Mark Hofstetter <[email protected]> --- I can confirm that Bug 42605 is not completely fixed in the Debian package `koha-common 26.05.04-1`. With: ``` AcqCreateItem = receiving UniqueItemFields = barcode|stocknumber ``` the receiving dialog remains stuck on its loading indicator. The item form is not loaded because JavaScript calls `.split("|")` on the numeric value `1`. The English template shipped with 26.05.04 contains: ```javascript AcqCreateItem: "[% Koha.Preference('AcqCreateItem') | html %]", UniqueItemFields: [% Koha.Preference('UniqueItemFields') ? 1 : 0 | html %], ``` The backport therefore corrected `AcqCreateItem`, but not `UniqueItemFields`. On main, commit `35b58d65c5` from Bug 43211 had already changed `UniqueItemFields` to a string before Bug 42605 commit `757b347bed` was applied. Consequently, the Bug 42605 commit only needed to modify `AcqCreateItem` on main. The 26.05.04 backport appears to have included `757b347bed` without the relevant change from `35b58d65c5`, leaving the fix incomplete on the stable branch. The required result is: ```javascript Koha.addPrefs({ AcqCreateItem: "[% Koha.Preference('AcqCreateItem') | html %]", UniqueItemFields: "[% Koha.Preference('UniqueItemFields') || '' | html %]", }); ``` Applying this change locally to the English and translated German templates and restarting Plack restored the acquisition receiving item form. Could the missing `UniqueItemFields` change please be added to `26.05.x` and included in the next maintenance release? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
