https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |k Status|Passed QA |Failed QA --- Comment #155 from Pedro Amorim (ammopt) <[email protected]> --- Hi all, some things worth addressing here: - Finding 1 is a blocker: it breaks the default config. - Findings 2 and 3 are regressions with small fixes. Setup: 1) Apply the patches, then: yarn build && restart_all Finding 1: holds history table breaks with DisplayAddHoldGroups off (the default) On main, this page breaks with the pref on (bug 41954). "(bug 41954 follow-up) Fix hold_group_id" fixes that, but the JS column list in holdshistory.tt is still conditional on display_hold_group_id, so it now breaks with the pref off instead. The holds.js fix in "holds-table - Fix JS error when DisplayAddHoldGroups is off" is needed here too. 1) Make sure 'DisplayAddHoldGroups' is set to "Don't display": http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=DisplayAddHoldGroups 2) Place a hold for koha (patron 51) on any record: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=51 3) Open http://localhost:8081/cgi-bin/koha/members/holdshistory.pl?borrowernumber=51 with the browser console open. 4) The 'Current holds' table doesn't load, and the console shows: Uncaught TypeError: Cannot read properties of undefined (reading 'sClass') 5) Set 'DisplayAddHoldGroups' to "Display" and reload. The table loads. Finding 2: 'Additional fields' never shows in Z39.50 search results 1) Go to 'Administration' > 'Z39.50/SRU servers' > 'New Z39.50 server' and add: - Server name: INDEX DATA - Hostname: z3950.indexdata.com - Port: 210 - Database: marc - Syntax: MARC21/USMARC 2) Set 'AdditionalFieldsInZ3950ResultSearch' to: 001, 082$ab http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=AdditionalFieldsInZ3950ResultSearch 3) Go to 'Cataloging' > 'New from Z39.50/SRU', tick only 'INDEX DATA', enter "computer" in 'Title' and click 'Search'. 4) Results show, but there's no 'Additional fields' column, and 'Columns' doesn't offer it. Before the patches it showed the 001 and 082 values (e.g. 616.07/575/02854). If you want to compare the before and after, use a private window, as the saved table state can keep the column hidden. Finding 3: item type image column is inverted 1) Set 'noItemTypeImages' to "Don't show" and 'OpacNoItemTypeImages' to "Show": http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=ItemTypeImages 2) Open http://localhost:8081/cgi-bin/koha/admin/itemtypes.pl. The 'Image' column is missing. Before the patches it showed. 3) Set 'OpacNoItemTypeImages' to "Don't show" too and reload. Now an empty 'Image' column is shown. Before the patches there was no column. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
