https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43623
--- Comment #13 from Brendan Lawlor <[email protected]> --- Created attachment 207675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207675&action=edit Bug 43623: (QA follow-up) Respect rows per page when the report has a LIMIT On the first page of results, execute_query raised the page size to the report's own LIMIT whenever the page size was smaller. A report with LIMIT 50 always showed 50 rows on the first page, whatever was selected in "Rows per page", and the next pages repeated rows from it. The previous patch made this happen for "LIMIT offset, count" and "LIMIT count OFFSET offset" reports too, because the report's offset is now added after the check. This patch removes that branch. The check above it already stops each page at the report's LIMIT. Test plan: 1. Create a SQL report: SELECT itemnumber FROM items LIMIT 50 OFFSET 100 2. Run it and set "Rows per page" to 20 3. Note the first page still shows 50 rows 4. Apply this patch and restart_all 5. Run the report again with 20 rows per page 6. Note the first page shows 20 rows, and pages 2 and 3 show the next 20 and 10 without repeating any rows 7. Repeat with SELECT itemnumber FROM items LIMIT 50 and note the same 8. prove t/db_dependent/Reports/Guided.t Sponsored-by: CLAMS Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Brendan Lawlor <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
