https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43570

David Cook <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from David Cook <[email protected]> ---
Reading the description in more detail... what a weird situation.

So the problem is with the install_filter method which we don't use in most of
our Koha::Template::Plugin filter plugins... OK.

Looking at Template::Plugin::JSON::Escape it uses $context->define_filter() and
that $context gets saved within the $self... 

But the problem with install_filter is that it wraps the filter method with a
closure. 

I'm not sure of the significance of 3.1 as it seems the weaken fix was re-added
in 2.28 eight years ago. Of course, we're still on 2.27...

--

I'm going to fail this one as it looks like we're copying the 2.28 fix but
newer versions (like 2.29 and up) use the following:

weaken( $this->{_CONTEXT} ) if ref $this->{_CONTEXT}
            && !isweak $this->{_CONTEXT};

(See https://github.com/cpan-authors/Template2/issues/206)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to