https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42490

Pedro Amorim (ammopt) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |k
             Status|Passed QA                   |Failed QA

--- Comment #17 from Pedro Amorim (ammopt) <[email protected]> ---
Blocker:

After updatedatabase:

prove  t/db_dependent/check_sysprefs.t
t/db_dependent/check_sysprefs.t .. 
    #   Failed test 'LocalHoldsPriorityScope has 'explanation' set in DB, must
be NULL!'
    #   at t/db_dependent/check_sysprefs.t line 115.

    #   Failed test 'LocalHoldsPriorityScope has 'type' set in DB, must be
NULL!'
    #   at t/db_dependent/check_sysprefs.t line 118.
    # Looks like you failed 2 tests of 1804.
t/db_dependent/check_sysprefs.t .. 1/3



Non-blockers but nice to haves:

- 'checking items in' undersells it. CheckReserves (and so LocalHoldsPriority)
also runs at checkout, transfers, hold cancel/move and SIP, so checkin_only
really means "everywhere except the holds queue". Please make the label (and
ideally the value) say so, if that is indeed the case.
- Commit message: HoldsQueueOptimizeBranch should be
HoldsQueuePrioritizeBranch.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to