https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
--- Comment #267 from Katrin Fischer <[email protected]> --- Rebased patch set. There was a conflict in transferstoreceive.pl from bug 42443. It required a small follow-up to fix tests. (In reply to Pedro Amorim (ammopt) from comment #251) > Still a few bugs here: > #1 > A) Go to the KTD staff interface at > http://localhost:8081/cgi-bin/koha/admin/preferences. > pl?op=search&searchfield=UseRecalls and set 'UseRecalls' to any non-'off' > value, e.g. 'can be placed through the OPAC only'. > B) Log into the OPAC at http://localhost:8080/cgi-bin/koha/opac-user.pl as > any patron. > C) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl > D) Look for the recall-related notice row (item recalled / recall notices) — > it's missing, even though recalls are enabled. > E) Now flip 'UseRecalls' back to 'off' in step 1's page. > F) Reload http://localhost:8080/cgi-bin/koha/opac-messaging.pl — the recall > notice row now shows up, even though recalls are off. > G) Steps 4 and 6 are the reverse of what should happen — confirms the > condition is inverted. Small error in the logic, as we actually want to skip the line when UseRecalls == "off". One character fix done in follow-up. > #2 > A) Set 'UseRecalls' to 'staff' at > http://localhost:8081/cgi-bin/koha/admin/preferences. > pl?op=search&searchfield=UseRecalls > B) At http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl set the > default rule: 'Recalls allowed' = 5, 'Recalls per record' = 3, 'On shelf > recalls allowed' = 'if any unavailable' (not 'all'). > C) Use biblionumber '437' (has just one item, barcode '39999000019186'), > check that item out to 'Henry Acevedo' (Patron A). > D) Place a record-level hold on it for 'Johnny Bryan' (Patron B), who's from > 'Midway' — but set the hold's pickup location to 'Centerville' instead. > E) On > http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=437, tick > the hold, click 'Convert selected to recall', confirm. > F) Check the new recall's pickup location on > http://localhost:8081/cgi-bin/koha/recalls/request.pl?biblionumber=437 > > Expected: 'Centerville'. Actual: 'Midway' — pickup branch got silently > dropped and replaced with Johnny Bryan's home library. Also a small variable fix, changing $branchcode to $hold->branchcode to carry it over into the recall. Keeping fingers crossed and big thanks to the time you spent on writing these detailed notes and the great testing. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
