https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <[email protected]> --- 1) Files are not tidy, please make sure your dev env is current and that you run qa checks before submitting: Result: [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-profile.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-profile.tt` [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt` 2) Pre-filling fields 2) Clear 'Printer name' and/or 'Paper bin' and save. __(Without this patch both boxes are already empty; with it they arrive pre-filled with the defaults, so they have to be cleared first.)__ -- without this patch: the profile is silently stored with an empty value; saving a second such profile returns a 500 error page I have to admit I am not a fan of pre-filling the fields. * It only works for the first printer profile, after it causes an error and adds extra steps. * It doesn't translate. * It's inconsistent with everywhere else in Koha. * It's breaking capitalization rules... Koha/Schema/Result/PrintersProfile.pm: default_value: 'Default Printer' Koha/Schema/Result/PrintersProfile.pm: default_value => "Default Printer", installer/data/mysql/kohastructure.sql: `printer_name` varchar(40) NOT NULL DEFAULT 'Default Printer', Input fields should be empty when adding "new" and marked as required. Changing the database default would be a separate bug, but we should not change the behavior of the form to use those values. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
