https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41129
--- Comment #200 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 205593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205593&action=edit Bug 41129: (QA follow-up) Use the shared patron formatter from bug 43518 Replace the booking store's local transformPatronData()/ transformPatronsData() with patronToOption() from vue/utils/patron-options.js (bug 43518), removing a duplicated, incomplete reimplementation of Koha's patron name formatting rules -- the local version only used firstname/surname and never considered preferred_name. Configured with { invertName: true, displayCardnumber: true }, matching the display convention already used by the legacy patron_autocomplete() dropdown for the same kind of search-result context. This is a small, deliberate display change: the booking patron search now shows "Surname, Preferred (cardnumber)" instead of "Surname Firstname (cardnumber)". For the overwhelming majority of patrons these are equivalent, since Koha::Patron->store() defaults preferred_name to firstname whenever it is not explicitly set. Test plan: 1. Apply on top of bug 43518. 2. Run: yarn cypress run --component --browser electron 3. Verify all specs pass, including the new t/cypress/component/stores/bookingsStoreData_spec.ts. 4. Open the booking modal, search for a patron, and confirm the dropdown still shows sensible name/cardnumber/age/library metadata. Assisted-by: Sonnet 5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
