https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42505
--- Comment #5 from Martin Renvoize (ashimema) <[email protected]> --- Re QA question about the test plan (step 1 vs step 8 both setting HoldsAutoFill = "Don't"): This is intentional, not a copy/paste error. HoldsAutoFill controls whether the "Hold found" modal (which contains the "Print slip..." button this patch fixes) appears at all: - If HoldsAutoFill = "Do", the hold is auto-filled/transferred silently and the modal never appears, so the patched code path isn't exercised at all. - So HoldsAutoFill must stay "Don't" for both steps 1-7 and step 8 - there's no second syspref value being tested here. What differs between the two is the *hold scenario*, not the syspref: - Steps 2-7: pickup branch differs from the checkin branch -> "transfertodo" is true -> modal shows "Print slip, transfer, and confirm" - Step 8: pickup branch is the *same* as the checkin branch -> "transfertodo" is false -> modal shows "Print slip and confirm" instead Both buttons share the same click handler this patch touches (returns.tt), so step 8 is there to cover that second button/scenario, not a different HoldsAutoFill value. Happy to reword the commit's test plan if that would help future QA - let me know. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
