https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |Failed QA --- Comment #19 from Andrew Fuerste-Henry <[email protected]> --- David mentioned the need for a scrubber to prevent script injection. I'm getting an error from the QA tools and /kohadevbox/koha/xt/tt_script_tidy.t fails -- I guess the failures is really pointing at issues elsewhere in the code, rather than a problem with this patch. [FAIL] t/lib/plugins/Koha/Plugin/TestValuebuilder/test_valuebuilder_popup.tt FAIL valid_template : filter not found * Proving /kohadevbox/koha/xt/tt_script_tidy.t FAIL # Failed test 'koha-tmpl/intranet-tmpl/prog/en/includes/main-container.inc has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/includes/patron-detail-tabs.inc has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/includes/wrapper-staff-tool-plugin.inc has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/pos/printreceipt.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/intranet-tmpl/prog/en/modules/tools/restore-records.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Failed test 'koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt has a <script> tag with Template::Toolkit tags.' # at /kohadevbox/koha/xt/tt_script_tidy.t line 73. # got: '1' # expected: '0' # Looks like you failed 8 tests of 2434. /kohadevbox/koha/xt/tt_script_tidy.t .. Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/2434 subtests Test Summary Report ------------------- /kohadevbox/koha/xt/tt_script_tidy.t (Wstat: 2048 (exited 8) Tests: 2434 Failed: 8) Failed tests: 439, 583, 787, 1306, 1366, 1615, 1891, 2377 Non-zero exit status: 8 Files=1, Tests=2434, 1 wallclock secs ( 0.06 usr 0.01 sys + 0.20 cusr 0.03 csys = 0.30 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
