https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41714
--- Comment #31 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 205224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205224&action=edit Bug 41714: (QA follow-up) Scope the framework auth_type override to bib headings only parse_heading() applied a bib-framework tag-to-authtype override unconditionally, without checking the $auth parameter, so it also affected parsing of a heading taken from an authority record's own field (auth => true), not just bib headings. Koha::Authority->heading_object, Koha::SearchEngine::Elasticsearch's authority indexing, and misc/maintenance/dedup_authorities.pl all parse an authority record's own report-tag field this way. Since several authority main-entry tags (100, 110, 111, 130) share their tag number with a same-named bib field, a site customising e.g. bib tag 100's framework link (precisely what this preference is for) would have silently changed how a PERSO_NAME authority's own heading is classified too, even though a bib-to-authority linking customisation has nothing to do with what an authority record's heading tag means. No caller currently reads ->auth_type() off an authority-side heading object, so this had no live behavioural effect yet, but it was a latent trap for the next one that does. The override now only applies when $auth is false. Also documents, in the pref description and in C4::Heading::MARC21's POD, that this preference can only retarget a tag Koha already hardcodes as a heading field - unlike UNIMARC's fully framework-driven table, it cannot make Koha recognise a wholly new heading tag, since valid_heading_tag() still consults the hardcoded tables regardless of this preference. Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
