https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43448
--- Comment #2 from David Nind <[email protected]> --- Created attachment 204788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204788&action=edit Bug 43448: Remove meaningless conditional We are in a conditional based on AllowHoldPolicyOverride being enabled, a second conditional with an OR on the value will always be true To test: 1 - Do not apply patch 2 - Disable AllowHoldPolicyOverride 3 - Create a biblio B with an item I at library A. 4 - Configure this library A to not be a pickup location 5 - Add a "Default holds policy by item type" for item I type where "Hold pickup library match" is "item's home library" 6 - Try to place a hold on biblio B You should not be able to place a hold because there is no valid pickup locations 7 - Enable AllowHoldPolicyOverride 8 - Try to place a hold on biblio B You should now see all valid pickup locations in a dropdown list (with an exclamation mark in front of each option) with none selected by default 9 - Verify you can place a title-level hold and an item-level hold 10 - Apply patch, repeat test plan, verify nothing has changed Signed-off-by: David Nind <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
