https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43402
--- Comment #1 from Martin Renvoize (ashimema) <[email protected]> --- Scoping note: this patch adds the "Payment received" notification box (Print/Email receipt) for members/pay.tt and members/boraccount.tt, modeled directly on the pattern Bug 41705 introduced for pos/pay.tt ("Use PRG pattern for POS receipt printing to avoid popup blockers"). Both pages already receive payment_id/change_given via the existing redirects from members/paycollect.pl, and the email action reuses boraccount.pl's existing cud-send_receipt handler, so no controller changes were needed for this part. Worth noting as context: unlike POS after Bug 41705, this page still triggers its FinePaymentAutoPopup receipt via a plain client-side window.open() on page load (see boraccount.tt/pay.tt/paycollect.tt), which carries the same popup-blocker risk Bug 41705 fixed for POS. Porting that same PRG pattern here turned out to be more involved than a straight copy-paste, because paying/writing off a charge here can also trigger item renewal feedback (renew_result) and a refreshed balance view in the same tab that the popup currently supplements, rather than replaces. I've filed Bug 43451 to track that separately, with the design tradeoffs discussed there, so it can get proper consideration rather than being rushed through alongside this patch. Also see Bug 43288 (change/change_given param mismatch on these same printfeercpt.pl links) - this patch's new Print receipt links use the already-corrected change= param name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
