https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43449
Bug ID: 43449
Summary: Restore multi-value export formatting for additional
fields in datatables
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff interface
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Target Milestone: ---
When exporting a searchable, repeatable additional field to CSV/Excel from a
Vue-rendered datatable, all values are concatenated into one cell with no
separator (e.g. "Test 1Test2" instead of "Test 1, Test2").
Bug 41151 tried to fix this by rendering multi-value cells as newline-separated
text for export, but that conflicted with the DataTables Buttons export
sanitisation added for the CSV formula-injection fix (bug 37727), which strips
newlines. That patch was reverted there - see comment 33 on bug 41151.
At the time, correct handling of embedded newlines on export required
datatables.net-buttons >= 3.2.0 (which introduced escapeExcelFormula) and a
compatible datatables.net-vue3 >= 3.x (for DataTables 2.x/3.x support), while
Koha's package.json was pinned to datatables.net-buttons ^2.3.4 and
datatables.net-vue3 ^2.0.0.
As of now, upstream npm has moved well past those thresholds:
datatables.net-buttons is at 4.0.2, datatables.net-vue3 is at 3.0.8, and
datatables.net core is at 3.0.3. Koha's package.json still pins the old
versions, so the version blocker no longer applies, but the upgrade itself has
not been attempted.
This bug covers:
1. Upgrading datatables.net, datatables.net-buttons and datatables.net-vue3 to
current major versions compatible with each other.
2. Auditing KohaTable.vue and any other Vue call sites for breaking changes
introduced by those majors.
3. Re-implementing the export formatting half of the multi-value additional
fields display (reverted in bug 41151) using the newer Buttons' native
newline/escapeExcelFormula handling instead of the ad-hoc newline detection
that was reverted.
This is expected to be a substantial, standalone piece of work given how widely
the Vue datatable component is used across the app (ERM, ILL, vendors, etc.),
not a small follow-up patch.
Test plan:
N/A - no patch attached yet, this bug tracks the deferred scope described in
bug 41151 comment 33/34/53.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
