https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43355
--- Comment #14 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 203955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203955&action=edit Bug 43355: (QA follow-up) Fix critic, file permissions, and Test::NoWarnings in test files Test plan: 1. Enable Elasticsearch (e.g. `ktd --search-engine es8 up`, or your usual instance with ES enabled). 2. Catalogue two records: ZZZ43355ONE (title "The Stranger", author "Albert Camus", one available item) and ZZZ43355TWO (title "The Plague", author "Albert Camus", zero available items - e.g. all items withdrawn). 3. Rebuild indices: misc/search_tools/rebuild_elasticsearch.pl -a -r -v 4. GET /api/v1/search/biblios?q=camus as a logged-in catalogue user: expect both records, available: true for ONE and available: false for TWO. 5. GET /api/v1/search/biblios?q=title:stranger: expect only ONE. 6. GET /api/v1/search/biblios?q=camus&sort=title_asc: expect results ordered by title ascending. 7. GET /api/v1/search/biblios?q=camus&facets=itemtype: expect a facets.itemtype breakdown in the response. 8. GET /api/v1/search/biblios?q=notarealfield:camus: expect 400 with error_code INVALID_SEARCH_FIELD. 9. GET /api/v1/public/search/biblios?q=camus with no authentication at all: expect 200, same response shape. 10. Suppress ZZZ43355TWO (e.g. via its OpacSuppression field) and turn on the OpacSuppression system preference: repeat step 9 and confirm TWO no longer appears in the public route's results, but still appears in the authenticated route's results. 11. POST /api/v1/search/biblios with body {"q": "camus"}: expect the same shape as step 4. 12. POST /api/v1/search/biblios with body {"q": "camus", "_page": 2, "_per_page": 1}: expect page 2 of results, one result per page, matching what GET ...&_page=2&_per_page=1 returns for the same query. 13. Run the full test suite: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t \ t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t \ t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t \ t/db_dependent/api/v1/search_biblios.t All tests should pass. 14. Run the QA test tool and confirm it is happy with the whole patch set: koha-qa.pl -v 2 --more-tests -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
