https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35052
--- Comment #14 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 203935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203935&action=edit Bug 35052: (QA follow-up) Fix perlcritic and POD coverage findings - QueryBuilder.pm: replace explicit "return undef" with bare "return" in _resolve_opac_hidden_items_rules (perlcritic severity 5, PBP p.199) - Search.pm: add missing POD for _composite_item_aggregation and _get_item_counts_by_biblio; correct the POD block that had drifted onto _composite_item_aggregation when it actually documented _get_matching_biblionumbers' public contract (Task 1's refactor moved the sub the POD was written for without moving the POD itself) Test plan: 1) ktd --name "${KTD_INSTANCE:-kohadev}" --shell --run '/kohadevbox/qa-test-tools/koha-qa.pl -v 2 --more-tests' 2) Only remaining flagged item is a pre-existing critic finding on MockESSearchClient's package-vs-filename mismatch in t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t, inherited unchanged from Bug 43151 - not introduced or touched by this bug 3) ktd --name "${KTD_INSTANCE:-kohadev}" --shell --run 'prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t t/db_dependent/Koha/SearchEngine/Elasticsearch/Search.t' 4) All tests pass -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
