https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41048
--- Comment #27 from Kyle M Hall (khall) <[email protected]> --- Created attachment 199774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199774&action=edit Bug 41048: (QA follow-up) Address QA feedback This patch addresses the QA feedback on the previous patch: - Rename the system preference to EmptyPatronSearches and reframe the options as "Allow"/"Don't allow", defaulting to "Allow" so the current behaviour is unchanged - Fix the bad conflict resolution in sysprefs.sql - Count the library, category and sort filters as search criteria so the sidebar search button is enabled when any of them is set, not only when the search box contains text - Make the preference drive the header "Search patrons" form as well - Fix the atomicupdate description typo and report success or failure via say_success/say_failure Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Set the EmptyPatronSearches system preference to "Don't allow" 5) Browse to the patrons home page ( members-home.pl ) 6) Note the sidebar "Search for patron" button is disabled when the form is empty, and enabled once you enter a term or pick a library, category or sort filter 7) Note the header "Search patrons" search refuses an empty search 8) Set EmptyPatronSearches to "Allow" 9) Note empty searches are allowed again in both the sidebar and header! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
