https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42724
--- Comment #1 from Eric Phetteplace <[email protected]> --- I think I can explain why this is happening now. Circ > Check Out has a URL like /circ/circulation.pl?borrowernumber= but when you check out an item the URL updates to /circ/circulation.pl (no borrowernumber). You are still on the specific patron's check out page, though, with their check out and holds tables. The `holds_table_patron_page` function in staff-globals.js is specifically looking for URLs like "/circ/circulation.pl?borrowernumber=" however, so this no longer matches, and holds_table_patron_page() returns null. The holds.js code checks the return value of holds_table_patron_page() before adding a click handler to the #cancelModalConfirmBtn used in cancel-hold-modal: if (holds_table_patron_page()) { $("#cancelModalConfirmBtn").click(function (e) { e.preventDefault(); ... This code never executes because holds_table_patron_page() is null, the cancel button click handler isn't assigned, and cancel_holds() is never called. That's my theory at least, the holds.js file is complex. I'm not sure what the fix is, though: should checking out an item persist the borrowernumber in the URL? Should holds_table_patron_page have more logic for identifying when you're on a patron's circ page even though their borrowernumber is not in the URL? Is there a way to improve when the cancelModalConfirmBtn handler is added? I'm not sure what scenario is being worked around when we're not on a holds_table_patron_page and we don't want to assign this click handler. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
