https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42080

--- Comment #9 from David Cook <[email protected]> ---
(In reply to Eric Phetteplace from comment #8)
> Requires adding File::LibMagic to dependencies and libmagic on the host OS.
> The library doesn't appear to be in Koha's current cpanfile.

Bug 42087 will take care of that

> The whole file contents are fed to $magic which could be slow for large
> files, but then again those were already going to be even more slow to send
> over HTTP. File::LibMagic lets you initialize it with `max_bytes` param
> which might be useful if performance becomes an issue. Most files can be
> identified from very few bytes (e.g. PDF only takes 5).

Yeah that thought did cross my mind. I figured it's one of those "we'll cross
that bridge when we come to it" situations. But... You've got me thinking about
it some more. I might take a quick look at this to see if we can optimize a bit
more...

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to