https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42036
Bug ID: 42036
Summary: Add diff support to REPORTS action logs
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Transaction logs
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Blocks: 37940
The action logging for saved reports does not pass the $original parameter to
logaction(), so no structured diff is generated in the action_logs.diff column.
Currently log entries store the report name and SQL concatenated as a plain
string.
Affected calls:
- reports/guided_reports.pl MODIFY (~line 250):
logaction( "REPORTS", "MODIFY", $id, "$reportname | $sql" )
(no $original; only post-change state captured as a string)
- reports/guided_reports.pl ADD (~line 594):
logaction( "REPORTS", "ADD", $id, "$name | $sql" )
- C4/Reports/Guided.pm DELETE (~line 798):
logaction( "REPORTS", "DELETE", $id, $data->report_name . " | " .
$data->savedsql )
This bug covers updating these calls to pass structured hashrefs (e.g. {
report_name => ..., savedsql => ... }) as $infos and, for MODIFY, the
pre-change report data as $original, enabling proper before/after diff display
in the action log viewer.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940
[Bug 37940] [OMNIBUS] All modification logged via action logs should include
original to create JSON diff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
