https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42034
Bug ID: 42034
Summary: Add diff support to system preference action logs
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Transaction logs
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Blocks: 37940
The action logging in Koha/Config/SysPref.pm does not pass the $original
parameter to logaction(), so no structured diff is generated in the
action_logs.diff column.
Affected calls in Koha/Config/SysPref.pm:
- SYSTEMPREFERENCE/MODIFY or ADD (~line 47):
C4::Log::logaction( 'SYSTEMPREFERENCE', $action, undef, $self->variable . ' |
' . $self->value );
(concatenates variable name and new value into a string; no before state)
- SYSTEMPREFERENCE/DELETE (~line 63):
C4::Log::logaction( 'SYSTEMPREFERENCE', 'DELETE', undef, " $variable |
$value" );
System preference changes are important for configuration audit trails. This
bug covers updating store() in Koha::Config::SysPref to capture the pre-change
value and pass it as $original, and to pass a structured hashref (e.g. {
variable => ..., value => ... }) as $infos so the diff mechanism can produce a
clear before/after comparison.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37940
[Bug 37940] [OMNIBUS] All modification logged via action logs should include
original to create JSON diff
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
