https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41017

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #22 from Katrin Fischer <[email protected]> ---
I am sorry, but this still doesn't work as expected and the text was changed to
the simpler 'on hold' before in the cases it did show. Can you please have
another look?

1) QA checks

Is this something in my config not being right?

[FAIL] svc/checkouts
   FAIL   tidiness
                File is not tidy, please run `perl misc/devel/tidy.pl
svc/checkouts`

2) Testing

Test cases:
- Patron A with 3 checkouts from different records, all on hold for others
  1) renewal still possible
  2) overdue, renewals possible
  3) renewals maxed out

Expectation: 
- We want the system to ALWAYS show "on hold" for these checkouts, independent
of system preference settings.
  - in the list of checkouts initially
  - after override renewal is clicked
- Renewals of 'on hold' should be blocked with AllowRenewalOnHoldOverride "not
allow"

Testing:

Combination A:
- AllowRenewalLimitOverride = Allow
- AllowRenewalOnHoldOverride = Not allow
- OverduesBlockRenewing = block renewing for all

FAIL 
- All items show "no renewal allowed: overdue, 'on hold' is missing.
- Items can be renewed with override.

Combination B:
- AllowRenewalLimitOverride = Allow
- AllowRenewalOnHoldOverride = Not allow
- OverduesBlockRenewing = only this item

FAIL
- On hold information is only shown for 1 out of 3.
  1) OK renewal still possible
  2) FAIL overdue, renewals possible
  3) FAIL renewals maxed out
- Overdue item and maxed out renewals don't show 'hold' info (2 + 3)
- FAIL Item with option to renew shows 'hold info' (1), but new text "Item on
hold for another patron" is too long. Please change back to the "On hold"
previously used.

Combination C:
- AllowRenewalLimitOverride = Allow
- AllowRenewalOnHoldOverride = Not allow
- OverduesBlockRenewing = allow renewing

FAIL
- On hold inforation is only shown for 2 out of 3
  1) OK renewal still possible
  2) OK overdue, renewals possible
  3) FAIL renewals maxed out
- override renewal doesn't activate checkbox for visible 'on holds'

Combination D:
- AllowRenewalLimitOverride = Allow
- AllowRenewalOnHoldOverride = Allow
- OverduesBlockRenewing = allow renewing

FAIL
- On hold inforation is only shown for 2 out of 3
  1) OK renewal still possible
  2) OK overdue, renewals possible
  3) FAIL renewals maxed out
- override renewal does activate checkboxes for visible 'on holds' (OK, but
should be all 3)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to